Add offset to spectral transformations to enable shifted slits#875
Draft
Add offset to spectral transformations to enable shifted slits#875
Conversation
oczoske
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 74.83% 74.85% +0.02%
==========================================
Files 69 69
Lines 8868 8876 +8
==========================================
+ Hits 6636 6644 +8
Misses 2232 2232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack to enable simulations of offset slits in MICADO. The offset is in the dispersion direction and observations in the nominal and offset slits are meant to fill in missing data due to the gaps in the detector array. A proper implementation would use separate trace files computed for both slit positions. Here, offsets are determined from the
CRVALiDin the FOV header and added to the x and y arrays from which the transformations are computed. TheCRVALiDvalues are zero for nominal slits and non-zero for shifted slits. This works for MICADO, but it needs to be tested that it doesn't break METIS and other spectrographs.Related to AstarVienna/irdb#308